Skip to content

chore: use beta-9.1 instead of beta.10#5821

Merged
mark-wiemer merged 5 commits intomainfrom
fix-5763
Apr 2, 2026
Merged

chore: use beta-9.1 instead of beta.10#5821
mark-wiemer merged 5 commits intomainfrom
fix-5763

Conversation

@mark-wiemer
Copy link
Copy Markdown
Member

@mark-wiemer mark-wiemer commented Mar 26, 2026

PR Checklist

Overview

Core issue: beta-9 is reported as greater than beta-10 in semver string comparison, because - is not a proper semver separator. This means beta-10 is never "latest" when beta-9 exists.

To workaround this, settling on beta-9.1, beta-9.2, etc. for the remainder of the v12 betas . Then we will go to rc.1 and rc.2. Mocha 13 will use a normal beta.1, beta.2 approach, but Mocha 12 will suffer from our mistakes :D

Ref backing issue and #5821 as proof :)

This PR also adds some QoL to Release Please workflows for future diagnoses.

To get this PR to work, I manually pushed a new tag:

git tag v12.0.0-beta-9.1 v12.0.0-beta-10
git push origin v12.0.0-beta-9.1

Release Please reads git tag data, not just previous release commit data.

@mark-wiemer mark-wiemer changed the title Use beta-10.0 instead of trying beta.10 chore: use beta-10.0 instead of beta.10 Mar 26, 2026
@mark-wiemer mark-wiemer requested a review from a team March 26, 2026 01:06
@mark-wiemer mark-wiemer enabled auto-merge (squash) March 26, 2026 01:06
@mark-wiemer mark-wiemer disabled auto-merge March 26, 2026 01:06
@mark-wiemer mark-wiemer enabled auto-merge (squash) March 26, 2026 01:06
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (b0a89ce) to head (a4ecc77).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5821      +/-   ##
==========================================
- Coverage   89.70%   89.66%   -0.04%     
==========================================
  Files          64       64              
  Lines        4691     4695       +4     
  Branches      976      976              
==========================================
+ Hits         4208     4210       +2     
- Misses        483      485       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer mark-wiemer marked this pull request as draft March 26, 2026 14:21
auto-merge was automatically disabled March 26, 2026 14:21

Pull request was converted to draft

@mark-wiemer
Copy link
Copy Markdown
Member Author

I just realized we'll need to change beta-10 to beta-9.1 and start using beta-9.2 and beta-9.3. What a mess. @copilot help

@linux-foundation-easycla
Copy link
Copy Markdown

CLA Not Signed

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 26, 2026

I just realized we'll need to change beta-10 to beta-9.1 and start using beta-9.2 and beta-9.3. What a mess. @copilot help

Done in commit a4ecc77. Updated manifest.json, package.json, and the CHANGELOG.md header to use 12.0.0-beta-9.1 instead of beta-10.0. Future releases can continue as beta-9.2, beta-9.3, etc.

You'll also need to manually push a tag pointing beta-9.1 at the same commit as beta-10:

git tag v12.0.0-beta-9.1 v12.0.0-beta-10
git push origin v12.0.0-beta-9.1

Copilot AI changed the title chore: use beta-10.0 instead of beta.10 chore: use beta-9.1 instead of beta.10 Mar 26, 2026
@mark-wiemer mark-wiemer marked this pull request as ready for review March 31, 2026 20:58
@mark-wiemer
Copy link
Copy Markdown
Member Author

Ref Release Please run 284 which should actually work maybe

@mark-wiemer mark-wiemer added the status: needs review a maintainer should (re-)review this pull request label Apr 1, 2026
@mark-wiemer
Copy link
Copy Markdown
Member Author

Ready for review :)

Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mark-wiemer mark-wiemer merged commit bc1eff2 into main Apr 2, 2026
312 of 314 checks passed
@mark-wiemer mark-wiemer deleted the fix-5763 branch April 2, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs review a maintainer should (re-)review this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: beta versions should use semver-style dot numeric separator (instead of dash)

3 participants