split _mocha file

[Bamieh]

The change

bin/_mocha file is responsible for both configuring mocha from the cli flags and running mocha. This causes an issue, every tool that wants to add on top of the mocha cli must copy-paste the bin/_mocha code in their own repos.

This change separates the bin/_mocha file to two files.

• bin/base.js file which collects the cli flags and creates a configured mocha instance.
• bin/_mocha file which requires bin/base.js and runs the exported mocha instance.

Advantages:

• Libraries now can require mocha/bin/base instead of copy-pasting the code.
• I also needed this for mocha-watcher.
• separate concerns for easier code comprehension and maintenance.
• non-breaking change, just a win-win

[coveralls]

Coverage decreased (-61.8%) to 28.218% when pulling 6f7ff71 on _mocha into babd958 on master.

[outsideris]

Is this related with #2292 or #2578 ?

[outsideris]

Why the coverage decreased like that?

[Bamieh]

@outsideris i'm not sure! i added the file to the ignore but still, i'll look into it tomorrow

[Bamieh]

@outsideris i believe this is related to #2578 since it makes the CLI more usable, since the base file now exports the program and the configured mocha. Anyone that wants to run mocha from their own CLI tool can simply import the base.

I would definitely love to merge bin/_mocha and bin/mocha but this PR is not related to it.

[boneskull]

I'm going to guess the coverage drop (the Travis PR build shows many tests skipped) is because the files array is simply discarded in bin/base.js.

I'm not sure why some stuff is in bin/base.js and other stuff remains in bin/_mocha.

Would prefer bin/base.js had a more descriptive name and actually lived in lib/ (as well as bin/options.js).

[Bamieh]

@boneskull the base.js is responsible only for creating a mocha instance and configuring it. The _mocha file requires this file and runs the mocha instance, it also adds a custom behavior to what happens on exit and what to do in the watch mode.

I am +1 for moving these .js files to lib/bin/

[craigtaub]

@Bamieh does this change still apply now we have the separation inside /cli!?

[boneskull]

It's likely invalid, but I'd like to know if the refactors around yargs and such solve the problem about wrapping the Mocha CLI...

[boneskull]

closed by #3556