- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 345
fix: allow extensions other than .js
for non-manifest entries
#3775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ScriptedAlchemy
merged 3 commits into
module-federation:main
from
jbroma:fix/allow-other-extensions-in-entries
May 15, 2025
Merged
fix: allow extensions other than .js
for non-manifest entries
#3775
ScriptedAlchemy
merged 3 commits into
module-federation:main
from
jbroma:fix/allow-other-extensions-in-entries
May 15, 2025
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
🦋 Changeset detectedLatest commit: 9c91d85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Loading status checks…
ScriptedAlchemy
approved these changes
May 15, 2025
@jbroma run pnpm changeset add |
Loading status checks…
zackarychapple
approved these changes
May 15, 2025
mitchellrj
pushed a commit
to mitchellrj/module-federation-core
that referenced
this pull request
May 27, 2025
…le-federation#3775) Co-authored-by: Hanric <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, all remote entries must have
.json
or.js
in their name - in RN & when working on MF in Metro, the output usually ends with.bundle
and this limitation gets in the way in runtime.I'm marking this as a fix since there is no trace of having this as an actual requirement
Related Issue
n/a
Types of changes
Checklist