-
Notifications
You must be signed in to change notification settings - Fork 33
Split file into multiple modules #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @mogenson, |
Thank you for the long overdue refactor. Let me give it a try and I'll get back to you. |
Looks like there's an issue with the cycle window command:
|
I'm also seeing repeating events that don't stop (eg "windowFocused for ") in the Hammerspoon Console. I'll see if I can figure out what's causing them. |
Would you mind formatting the code? There's a CI code format lint results here: https://github.com/mogenson/PaperWM.spoon/actions/runs/14803256610/job/41584942320?pr=85 The lua-language-server picks up the format config from the top level |
Annoyingly I cannot find a way to invoke the code formatter without starting the language server RPC. Let me know if you have any issues configuring your editor to use https://github.com/LuaLS/lua-language-server |
Hi @mogenson, Besides that I think you're right: Some features seem to be buggy now. |
Thanks for fixing the lints. Since this is a big change, let's do it piece by piece and ensure no functionality is broken between changes. For example, first create and move things into There's now conflicts with the main branch so please rebase onto main. |
Split the init.lua file into the following structure:
PaperWM.spoon/
├── init.lua # Main entry point
├── modules/ # Module directory
│ ├── config.lua # Configuration and constants
│ ├── window_manager.lua # Window tracking and management
│ ├── layout_engine.lua # Layout algorithms
│ ├── space_manager.lua # Space navigation
│ └── action_manager.lua # User actions
└── external/
├── mission_control.lua # Mission Control integration
└── swipe.lua # Swipe gesture detection
and added comments to the files (automatically)