remove cached password from Wallet API (master) #10232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include changes from monero-project#9492 Co-Authored-By: DiosDelRayo
iamamyth
reviewed
Nov 25, 2025
| m_wallet->store_to(path, epee::wipeable_string((*password).first, (*password).second)); | ||
| } else { | ||
| m_wallet->store_to(path, m_password); | ||
| setStatusError("Failed to store wallet to new path without password."); |
There was a problem hiding this comment.
This seems to imply an intermittent or recoverable failure; suggest something like: Saving the wallet to a new path requires a password.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #9464
#9915 is the old release version of this PR, I plan to update later