Skip privacy networks (on tx sends) that don't have outgoing connections [0.18] #9267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I wanted to make this is a draft, oh well @selsta I will post the |
Contributor
|
Thank you 🙏 |
Contributor
|
i first became aware of this bug after @nahuhh mentioned having similar issues with i2p / confirmed it was happening (along with the i2p phantom/double port issue), this is a very important fix. if you consider that i am hosting public nodes who can without notice behave like a malicious one not broadcasting peoples transactions it is quite stressful. will be testing this |
selsta
approved these changes
Apr 15, 2024
Contributor
|
I'll test for a few days and report back. |
Contributor
|
tested for a couple weeks on android with external i2p |
nahuhh
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will check if the privacy network has outgoing connections before attempting to send over that network. The primary difference is that this will allow sending txes over Tor if I2P has no outgoing connections.
This differs from the PR yesterday in that it checks the outgoing checks directly instead of the count reported by the noise code.