Skip to content

Conversation

@nahuhh
Copy link
Contributor

@nahuhh nahuhh commented Jun 12, 2025

release version of #9953 / #8981

@nahuhh
Copy link
Contributor Author

nahuhh commented Jun 13, 2025

I've tested wallet-cli's set subaddress-lookahead and it works as expected.

things to note:

  • this does not work retroactively. If you missed any transactions, you'll have to scan_tx for them
  • wallet-rpc is not persistent. I'm not sure how this behaves in practice. Example: change lookahead from default 200 to 500 -> receive tx on minor index 500 -> lookahead is now to index 1000 -> restart wallet = does the wallet forget about subaddress 701-1000? Or does it just not expand until it reaches 800 now?

future:

  • wallet-rpc should be made persistent, perhaps in a follow-up pr.
  • perhaps subaddress-lookahead should rollback the wallet height to the last known transaction, so missed transactions are found automatically

@plowsof
Copy link
Contributor

plowsof commented Jun 14, 2025

wallet-rpc is not persistent.

Currently wallet rpc cache has to be saved manually with store, i dont know of anything which triggers store off the top of my head. *ctrl+c? 😄

@plowsof
Copy link
Contributor

plowsof commented Jun 17, 2025

i've went down a rabbit hole sanity checking the effects of changing set subaddress-lookahead without this patch, these instructions will help us to test this PR #7364 (comment)

@nahuhh nahuhh force-pushed the pr/8981_release branch from 9036c71 to bebef64 Compare July 3, 2025 16:11
@nahuhh nahuhh force-pushed the pr/8981_release branch from bebef64 to 1da19da Compare July 7, 2025 22:22
@tobtoht tobtoht merged commit 8b4f0a6 into monero-project:release-v0.18 Jul 10, 2025
18 checks passed
silverpill pushed a commit to silverpill/monero-rpc-rs that referenced this pull request Sep 20, 2025
silverpill added a commit to monero-rs/monero-rpc-rs that referenced this pull request Sep 20, 2025
* Test against monero 0.18.3.3

* RPC version update

Version increased in monero-project/monero#8945

* Test against monero 0.18.3.4

* Set unlock_time to 0

monero-project/monero#9151

* Test against Monero 0.18.4.0

* Wallet RPC version update

Version increased in monero-project/monero#9788

* Change expected error message in tests

* Test against Monero 0.18.4.1

* Wallet RPC version update

Version increased in monero-project/monero#9954

* Test against Monero 0.18.4.2

---------

Co-authored-by: silverpill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants