Skip to content

Run go mod tidy before vendoring in compilecheck.#1620

Merged
matthewdale merged 1 commit intomongodb:v1from
matthewdale:fix-compilecheck-tidy
Apr 25, 2024
Merged

Run go mod tidy before vendoring in compilecheck.#1620
matthewdale merged 1 commit intomongodb:v1from
matthewdale:fix-compilecheck-tidy

Conversation

@matthewdale
Copy link
Copy Markdown
Contributor

Summary

Run go mod tidy before go mod vendor in the compile check script.

Background & Motivation

Github Dependabot PRs that update dependencies (e.g. #1619) fail the build check while running etc/compile_check.sh because of error:

+ GC=go
+ COMPILE_CHECK_DIR=internal/test/compilecheck
+ DEV_MIN_VERSION=1.19
+ compile_check
+ cd internal/test/compilecheck
+ go mod vendor
go: updates to go.mod needed; to update it:
        go mod tidy

That is caused by running go mod vendor after changing some dependency version in the go.mongodb.org/mongo-driver module. We already run go mod tidy later in the script, but need to run it earlier to avoid the above error.

Copy link
Copy Markdown
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot Bot added the review-priority-low Low Priority PR for Review: within 3 business days label Apr 25, 2024
@mongodb-drivers-pr-bot
Copy link
Copy Markdown
Contributor

API Change Report

No changes found!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-priority-low Low Priority PR for Review: within 3 business days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants