GODRIVER-2667 Replacing the assert.Soon with the assert.Eventually function#1668
Merged
timothy-kim-mongo merged 19 commits intomongodb:v1from Jun 14, 2024
Merged
Conversation
mongodb-drivers-pr-bot
Bot
added
dependencies
Contributor
API Change ReportNo changes found! |
prestonvasquez
requested changes
Jun 10, 2024
Member
|
@timothy-kim-mongo Could you update the title of this PR to reflect the changes being made? |
timothy-kim-mongo
changed the title
timothy-kim-mongo
changed the title
Contributor
Author
Sounds good, just made the title change along with the other changes you mentioned! |
prestonvasquez
requested changes
Jun 10, 2024
prestonvasquez
requested review from
blink1073
and removed request for
matthewdale
prestonvasquez
previously approved these changes
Jun 11, 2024
Member
prestonvasquez
left a comment
prestonvasquez
left a comment
There was a problem hiding this comment.
Please go through the remaining assert.Eventually tests and apply the changes we made for client_test.go.
timothy-kim-mongo
force-pushed
the
GODRIVER-2667
branch
from
f200ffd to
2aab105
Compare
prestonvasquez
requested changes
Jun 12, 2024
timothy-kim-mongo
force-pushed
the
GODRIVER-2667
branch
from
4561240 to
9ec3cc7
Compare
prestonvasquez
requested changes
Jun 12, 2024
timothy-kim-mongo
force-pushed
the
GODRIVER-2667
branch
from
09a6f43 to
9991b86
Compare
This was referenced Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GODRIVER-2667
Summary
The changes in this pull-request answers the ticket GODRIVER-2667 of replacing the assert.Soon with the assert.Eventually function. It may useful to note that assert.Eventually used in the code does not check initially whether the condition is satisfied meaning it must wait a minimum of the tick duration as according to #1424.
Background & Motivation
In removing the testify dependency and using a vendored subset (GODRIVER-2179), there were a number of calls to assert.Soon that became helpers.AssertSoon (testify has no perfectly analogous function). The motivation was to remove helpers.AssertSoon and refactor all calls to use assert.Eventually.