GODRIVER-2395 Never return errors when attempting to contact OCSP responders.#926
Merged
matthewdale merged 2 commits intomongodb:masterfrom May 2, 2022
Merged
Conversation
matthewdale
force-pushed
the
godriver2395-no-ocsp-errors
branch
from
4fc854e to
6271dc5
Compare
kevinAlbs
approved these changes
Apr 27, 2022
Contributor
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM! Nice simplification of the five second timeout.
benjirewis
approved these changes
Apr 27, 2022
Contributor
benjirewis
left a comment
benjirewis
left a comment
There was a problem hiding this comment.
Awesome, nice new tests!
Co-authored-by: Kevin Albertson <kevin.albertson@10gen.com>
matthewdale
force-pushed
the
godriver2395-no-ocsp-errors
branch
from
8e5a1ee to
815e46a
Compare
Contributor
Author
|
I added all the OCSP tests to the Evergreen run. All failures are for server v5.0, which are unrelated to this change, or for the Windows OCSP build, which fails for unrelated reasons. Merging. |
matthewdale
added a commit
that referenced
this pull request
May 2, 2022
matthewdale
added a commit
that referenced
this pull request
May 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GODRIVER-2395
Currently, the OCSP certificate status fetching code in the Go Driver (run when the certificate status is not stapled to the certificate) will return an error if the passed-in Context is cancelled or passes its deadline (see here). However, the OCSP spec describes that drivers should "soft fail" (i.e. fail to return a conclusive status but also not return any errors) anytime the OCSP responders are unreachable for any reason.
Update the OCSP certificate status fetching code to never return errors.