Skip to content

Create .gitlab-ci.yml #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

umlaeute
Copy link
Contributor

@umlaeute umlaeute commented Mar 3, 2022

This is partB of a revamped version of #504, that only includes the ".gitlab-ci.yml" changes.

this PR has squashed the various commits that change this file.

please note that there are some things i find a bit weird about this PR:

  • this uses syso/giada-builder as the Docker base image, rather than monocasual/giada-docker
  • I don't know anything about the details, but the latter seems to be the more natural choice...
  • it seems that giada is not using GitLab at all, so I see little point in having a CI-configuration for it.
    • I have rather strong feelings about git-providers encouraging people to leave their hoster-specific marks everywhere in the repository
    • GitLab at least offers the possibility, to add a URL as the CI-configuration, and you can do that in the project settings. so you don't really need to put that file into the repository itself (esp. if you don't use GitLab as the main provider)

Only include giada binary in build artifacts.
Disable PulseAudio and Alsa by default.
@gvnnz
Copy link
Contributor

gvnnz commented Mar 3, 2022

Yeah, I actually don't know why this PR was proposed in the first place. We run our CI on GitHub Actions, adding another one would be a) pointless b) a maintenance burden. Thanks anyway for the effort!

@gvnnz gvnnz closed this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants