[MD-1066] Container chain sending tokens to Ethereum #1100

evgeny-s · 2025-06-18T10:07:14Z

Description:
This PR provides a functionality for container chains to send tokens to Ethereum via the Relay chain

NOTE:
Should be merged after #1054

The plan:

Implement XCM Router on the container chain side
Cover container chains with dev tests
Implement/Re-use XCM Message Exporter on the relay chain side
E2E test
Documentation
Cover relay chain with dev tests
Cover corner cases with tests
Add more tests for potential vulnerabilities exposing

- Updated xcm message

- Moved test to zombienet setup

- Updated sender

evgeny-s · 2025-06-18T11:38:21Z

chains/container-chains/runtime-templates/frontier/src/lib.rs

+        /// to is the Ethereum mainnet, with chain ID 1.
+        /// <https://chainlist.org/chain/1>
+        /// <https://ethereum.org/en/developers/docs/apis/json-rpc/#net_version>
+        pub EthereumNetwork: NetworkId = NetworkId::Ethereum { chain_id: 11155111 };


We might want to find a way to pull it from the relay chain, because it should work for both: dancelight/stagelight runtimes.
Or maybe add here EthTestnet and EthMainnet and check for OR

We can add the runtime api to relay chain that will return the ETH NetworkId of the relay chain and then call this api before the validation

Or fetch it via the XCM message

Maybe having a testnet/mainnet flag could be useful for other things. But it adds an extra step to the deploy process... How can we make it automatic?

Just an idea: we could also have this EthereumNetwork as a param of pallet_parameters, and that way we would be able to modify it accordingly. This wouldn't be automatic tho, we can set a default value (e.g the testnet one) but if we want to change it in a mainnet environment, it should be done by calling the extrinsic.

- Added template impl for the MessageExporter - Removed failing test for MessageExporter -

- Extended e2e tests - Mocked the barrier - Added documentation

chains/orchestrator-relays/runtime/dancelight/src/xcm_config.rs

evgeny-s · 2025-06-25T12:01:37Z

chains/orchestrator-relays/runtime/dancelight/src/weights/xcm/pallet_xcm_benchmarks_generic.rs

@@ -327,6 +327,30 @@ impl<T: frame_system::Config> WeightInfo<T> {
 		// Minimum execution time: 1_199_000 picoseconds.
 		Weight::from_parts(1_243_000, 0)
 	}
+	// Storage: `ParachainInfo::ParachainId` (r:1 w:0)


Took it from BridgeHub for now, we will need to re-generate it on our side.

Yes, to generate our own benchmarks for ExportMessage we will need to adapt a few configurations for our implementation of pallet_xcm_benchmarks, like these ones:

https://github.com/moondance-labs/tanssi/blob/master/chains/container-chains/runtime-templates/frontier/src/lib.rs#L1281

https://github.com/moondance-labs/tanssi/blob/master/chains/container-chains/runtime-templates/frontier/src/lib.rs#L1343

…nerChainBarrier

evgeny-s · 2025-06-25T13:18:27Z

chains/xcm-integration-tests/emulated/tests/assets/dancelight/src/tests/xcm_message_exporter.rs

@@ -52,25 +51,3 @@ fn test_message_exporter_disabled_for_origin_account() {
        );
    });
 }
-
-#[test]


Removing this test, because we now using the MessageExporter

- Return NotApplicable in validate function

chains/orchestrator-relays/runtime/dancelight/src/xcm_config.rs

…into (3)-MD-1066-evgeny-container-to-eth-xcm # Conflicts: # primitives/bridge/src/lib.rs

…-container-to-eth-xcm # Conflicts: # chains/orchestrator-relays/runtime/dancelight/src/xcm_config.rs

…-container-to-eth-xcm

github-actions · 2025-07-07T08:50:32Z

WASM runtime size check:

Compared to target branch

dancebox runtime: 1500 KB (no changes) ✅

flashbox runtime: 884 KB (no changes) ✅

dancelight runtime: 2408 KB (+4 KB) 🚨

starlight runtime: 2312 KB (+4 KB) ⚠️

container chain template simple runtime: 1160 KB (-4 KB) ✅

container chain template frontier runtime: 1448 KB (+4 KB) ⚠️

evgeny-s and others added 17 commits June 18, 2025 12:06

- Initial version

fdb89e0

- Pick the asset from xcm message instead of SelfReserve

fd8eb97

- Added mint, updated xcm, updated benificiary

2c67a87

- Try polkadotXcm execute

5aac399

- Updated integration test

b1e3978

- Use raw xcm object

af51a4e

- Updated destination

262e3d1

- Updated xcm message

- Fix for router

c0de709

- Moved test to zombienet setup

- minor types fix

26de9a1

- use AccountKey20 instead of instead of AccountId32

c300e6d

- Updated tests

47191ed

- Updated sender

use proper ump router in exporter

57aa84e

- Updated to sovereign account

6df16fa

- Move test to container chain

d32567e

- Move the exporter to primitives

ff1838e

- Replicate XCM setup to simple container chain

8bb4a05

- Clean up test

fb980d8

evgeny-s mentioned this pull request Jun 18, 2025

[MD-1066] Container chain sending tokens to Ethereum #1099

Closed

evgeny-s changed the title ~~[MD-1066] Container chain sending tokens to Ethereum(3) md 1066 evgeny container to eth xcm~~ [MD-1066] Container chain sending tokens to Ethereum Jun 18, 2025

evgeny-s added 2 commits June 18, 2025 13:32

- Clean up

2b524af

- Group imports

1c0739e

evgeny-s commented Jun 18, 2025

View reviewed changes

evgeny-s marked this pull request as draft June 18, 2025 14:26

WIP:

e131df0

- Added template impl for the MessageExporter - Removed failing test for MessageExporter -

evgeny-s added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jun 20, 2025

- Added Message exporter

d7e9a08

- Extended e2e tests - Mocked the barrier - Added documentation

evgeny-s marked this pull request as ready for review June 24, 2025 13:01

evgeny-s commented Jun 24, 2025

View reviewed changes

chains/orchestrator-relays/runtime/dancelight/src/xcm_config.rs Outdated Show resolved Hide resolved

evgeny-s added 2 commits June 25, 2025 12:54

- Fixed CI checks

1c21c19

- Fixed clippy error

f16be97

evgeny-s added the not-breaking Does not need to be mentioned in breaking changes label Jun 25, 2025

- Removed unused imports

417074c

evgeny-s commented Jun 25, 2025

View reviewed changes

evgeny-s added 2 commits June 25, 2025 15:12

- Removed mocked barrier and implemented AllowExportMessageFromContai…

f8d9f6b

…nerChainBarrier

- Removed unused ParentOrParentsPlurality

08fb1b8

evgeny-s commented Jun 25, 2025

View reviewed changes

evgeny-s added 4 commits June 25, 2025 15:21

- removed unused RelayTreasuryLocation

4c8d613

- Made unlimited weight for the request

81817ef

- Fix frontier test

2745b9c

- Return NotApplicable in validate function

- Updated the UmpRouter usage

2e441d2

evgeny-s added the A8-mergeoncegreen Pull request is reviewed well. label Jun 25, 2025

evgeny-s added 2 commits June 25, 2025 18:40

- Added check for fees mode to the barrier to make it stricter

c22696a

- Added tests for container templates

2c59787

Agusrodri reviewed Jun 27, 2025

View reviewed changes

chains/orchestrator-relays/runtime/dancelight/src/xcm_config.rs Outdated Show resolved Hide resolved

evgeny-s added 5 commits June 30, 2025 10:52

- Reverted Barrier configuration

408ccca

Merge remote-tracking branch 'origin/jeremy-send-tokens-to-ethereum' …

e7bd79f

…into (3)-MD-1066-evgeny-container-to-eth-xcm # Conflicts: # primitives/bridge/src/lib.rs

Merge branch 'jeremy-send-tokens-to-ethereum' into (3)-MD-1066-evgeny…

23a7206

…-container-to-eth-xcm # Conflicts: # chains/orchestrator-relays/runtime/dancelight/src/xcm_config.rs

- warning fix

204d34e

Merge branch 'jeremy-send-tokens-to-ethereum' into (3)-MD-1066-evgeny…

fba4299

…-container-to-eth-xcm

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MD-1066] Container chain sending tokens to Ethereum #1100

[MD-1066] Container chain sending tokens to Ethereum #1100

Uh oh!

evgeny-s commented Jun 18, 2025 •

edited

Loading

Uh oh!

evgeny-s Jun 18, 2025 •

edited

Loading

Uh oh!

evgeny-s Jun 25, 2025 •

edited

Loading

Uh oh!

evgeny-s Jun 25, 2025

Uh oh!

tmpolaczyk Jun 26, 2025

Uh oh!

Agusrodri Jun 26, 2025

Uh oh!

Uh oh!

evgeny-s Jun 25, 2025

Uh oh!

Agusrodri Jun 26, 2025 •

edited

Loading

Uh oh!

evgeny-s Jun 25, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 7, 2025

Uh oh!

Uh oh!

@@ @@ -52,25 +51,3 @@ fn test_message_exporter_disabled_for_origin_account() { @@
                       );
                   });
               }
-              #[test]

[MD-1066] Container chain sending tokens to Ethereum #1100

Are you sure you want to change the base?

[MD-1066] Container chain sending tokens to Ethereum #1100

Uh oh!

Conversation

evgeny-s commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evgeny-s Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evgeny-s Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evgeny-s Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

tmpolaczyk Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

Agusrodri Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

evgeny-s Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

Agusrodri Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evgeny-s Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 7, 2025

WASM runtime size check:

Compared to target branch

Uh oh!

Uh oh!

evgeny-s commented Jun 18, 2025 •

edited

Loading

evgeny-s Jun 18, 2025 •

edited

Loading

evgeny-s Jun 25, 2025 •

edited

Loading

Agusrodri Jun 26, 2025 •

edited

Loading