Skip to content

[Do not Merge]Enable eth foreign asset registration in starlight #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dimartiro
Copy link
Contributor

Description

Enable ethereum foreign assets registration in starlight through pallet_foreign_asset_creator ensuring only root can create, modify or destroy these tokens.
This aims to register ethereum tokens only but since we don't have a way to filter that in pallet_foreign_asset_creator we decided to only allow root for this calls.

Note: weights were taken from dancelight (as the other weights in starlight)

Summary

  • Add required pallets pallet_assets and pallet_foreign_asset_creator
  • Add benchmarks
  • Integration tests

@dimartiro dimartiro self-assigned this Apr 25, 2025
Copy link
Contributor

github-actions bot commented Apr 25, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1524 KB (no changes) ✅

flashbox runtime: 888 KB (no changes) ✅

dancelight runtime: 2332 KB (no changes) ✅

container chain template simple runtime: 1168 KB (no changes) ✅

container chain template frontier runtime: 1456 KB (no changes) ✅

@dimartiro dimartiro changed the title Diego starlight foreign asset registration starlight eth foreign asset registration Apr 25, 2025
@dimartiro dimartiro changed the title starlight eth foreign asset registration Enable eth foreign asset registration in starlights Apr 25, 2025
@dimartiro dimartiro changed the title Enable eth foreign asset registration in starlights Enable eth foreign asset registration in starlight Apr 25, 2025
@dimartiro dimartiro added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 25, 2025
@dimartiro dimartiro requested a review from a team April 25, 2025 21:58
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Coverage Report

(master)

@@                              Coverage Diff                               @@
##           master   diego-starlight-foreign_asset_registration      +/-   ##
==============================================================================
- Coverage   64.87%                                       64.65%   -0.22%     
+ Files         478                                          480       +2     
+ Lines       78134                                        78603     +469     
==============================================================================
+ Hits        50688                                        50814     +126     
+ Misses      27446                                        27789     +343     
Files Changed Coverage
/chains/orchestrator-relays/runtime/starlight/src/lib.rs 36.58% (+0.14%)
/chains/orchestrator-relays/runtime/starlight/src/tests/integration_test.rs 99.84% (+0.04%)

Coverage generated Wed Apr 30 13:26:19 UTC 2025

@dimartiro dimartiro force-pushed the diego-starlight-foreign_asset_registration branch from 6d6a0cb to b3faebc Compare April 30, 2025 12:26
@girazoki girazoki changed the title Enable eth foreign asset registration in starlight [Do not Merge]Enable eth foreign asset registration in starlight May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant