Skip to content

Do dtype conversion in torch hook to save memory #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2024
Merged

Do dtype conversion in torch hook to save memory #1384

merged 3 commits into from
Jul 23, 2024

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Jul 22, 2024 •
edited
Loading

Unit tests

Existing unit tests should cover this change.

Manual tests

Before
image

After

image

@irenedea irenedea requested a review from a team as a code owner July 22, 2024 23:35
dakinggg
dakinggg approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you get @bigning to take a look too please?

snarayan21
snarayan21 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! minor comment

@irenedea
update code comment
26db1c2 
Co-authored-by: Saaketh Narayan <[email protected]>
bigning
bigning reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@bigning bigning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the change!

@irenedea irenedea enabled auto-merge (squash) July 23, 2024 01:21
@irenedea irenedea merged commit 596dd9d into mosaicml:main Jul 23, 2024
9 checks passed
@dakinggg dakinggg mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigning bigning bigning approved these changes

@snarayan21 snarayan21 snarayan21 approved these changes

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irenedea @bigning @snarayan21 @dakinggg