Skip to content

Fix reuse kv cache for torch attention #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2024
Merged

Fix reuse kv cache for torch attention #1539

merged 3 commits into from
Sep 22, 2024

Conversation

ShashankMosaicML
Copy link
Contributor

@ShashankMosaicML ShashankMosaicML commented Sep 21, 2024 •
edited
Loading

Fixes KV cache reuse for torch attention. Also modifies KV cache reuse tests to also test for torch attention.

@ShashankMosaicML ShashankMosaicML marked this pull request as ready for review September 21, 2024 06:49
@ShashankMosaicML ShashankMosaicML requested a review from a team as a code owner September 21, 2024 06:49
@ShashankMosaicML ShashankMosaicML merged commit d7c7822 into mosaicml:main Sep 22, 2024
9 checks passed
@ShashankMosaicML ShashankMosaicML deleted the fix_reuse_kv_torch branch September 22, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShashankMosaicML @dakinggg