Bump FA2 to 2.7.4.post1 #1728
Merged
Bump FA2 to 2.7.4.post1 #1728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuuCi
force-pushed
the
bump-fa2-2.7.4.post1
branch
from
05540ed to
0452eaf
Compare
KuuCi
force-pushed
the
bump-fa2-2.7.4.post1
branch
from
7e4d317 to
2adebe4
Compare
dakinggg
reviewed
Mar 3, 2025
7 tasks
added 3 commits
March 3, 2025 11:01
dakinggg
reviewed
Mar 5, 2025
dakinggg
reviewed
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FA2 2.6.3 doesn't support wheels with torch >2.4
FA updated the unpadding return values to return 5 outputs instead of 4:
https://github.com/Dao-AILab/flash-attention/blob/08f4c802c450708a86a92b226cba5663be81aead/flash_attn/bert_padding.py#L98
MPT doesn't actually support this FA change so we will gracefully fail MPT
Testing:
Regression test: https://databricks.slack.com/archives/C05T1A4UMT8/p1741210602072179