Allow subselecting the appropriate config for llama4 #1815
Merged
+152
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
changed the title
bowenyang008
reviewed
May 5, 2025
bowenyang008
reviewed
May 5, 2025
ethantang-db
reviewed
May 5, 2025
irenedea
reviewed
May 5, 2025
Co-authored-by: Irene Dea <[email protected]>
ethantang-db
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multimodal models may return a config with subconfigs from
AutoConfig. This PR allows subclasses to automatically select a subconfig (and sets up the causal LM training class to select text config). With this, llama4 scout finetuning works (llama4-scout-hf-real-7-a3JTUJ). llama4 also works with flex attention (llama4-scout-hf-flex-1-EUH7iy)Along for the ride, install the new HF extra that supposedly speeds up download
hf_xet, and bumps the minimum hf hub version that supports it.