Convert test suite to use sinon assertions

[kumar303]

Is this a feature request or a bug?

feature

What is the current behavior?

In the test suite we do things like this to check that stub objects are called correctly:

assert.ok(addonReload.called);
assert.equal(addonReload.firstCall.args[0].addonId,
  tempInstallResult.addon.id);

What is the expected or desired behavior?

It works but the failure messages could be better. Let's switch all of this code to sinon assertions instead.

The above test would be rewritten as:

sinon.assert.calledWith(
  addonReload, sinon.match({addonId: tempInstallResult.addon.id})
);

[wagnerand]

Mentor: @kumar303

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

[Jp-Rivera]

Hello @kumar303, I would like to work on this issue. It will be my first.

[kumar303]

Hello @Jp-Rivera and welcome! Let me know if you have any questions on how to get started. This guide will help you get set up for development.

You can try a search like this to look for code that needs updating. For your first pull request, I'd recommend only changing a few assertions and asking for a review so that we know you are on the right track.

[Jp-Rivera]

Hi @kumar303, I have submitted a pull request. There seems to be a problem with a capitalization in my commit message. The Travis CI build failed. How can I fix this?

[kumar303]

Sorry about that. This automated check is very picky. It looks like you fixed it by changing the pull request title (which is the right way to fix it) but the build will only start passing after you push a new commit.

[Jp-Rivera]

Hi @kumar303, I have submitted another pull request with some more sinon assertions for your review here.

[caitmuenster]

Hey @Jp-Rivera, thanks for the pull request with the sinon assertions! How's it going with this bug?