Skip to content

fix(deps): Update dependency adbkit to v3.2.3 #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2022
Merged

Conversation

rpl
Copy link
Member

@rpl rpl commented May 21, 2022

No description provided.

@rpl rpl force-pushed the fix/update-to-adbkit-v3 branch 8 times, most recently from d04b340 to a961bfa Compare May 22, 2022 15:41
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #2397 (911c750) into master (666886f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2397   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          32       32           
  Lines        1701     1701           
=======================================
  Hits         1699     1699           
  Misses          2        2           
Impacted Files Coverage Δ
src/util/adb.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666886f...911c750. Read the comment docs.

@rpl rpl force-pushed the fix/update-to-adbkit-v3 branch 5 times, most recently from ecde6ae to 1c3327a Compare May 23, 2022 12:00
@rpl rpl force-pushed the fix/update-to-adbkit-v3 branch from 1c3327a to a67ec50 Compare May 23, 2022 12:05
@rpl rpl requested a review from willdurand May 23, 2022 12:06
Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc but I think you should extract the CI changes in a separate PR.

@rpl rpl force-pushed the fix/update-to-adbkit-v3 branch from a67ec50 to 911c750 Compare May 23, 2022 12:30
@rpl
Copy link
Member Author

rpl commented May 23, 2022

r+wc but I think you should extract the CI changes in a separate PR.

I'm going to merge this using "Rebase and merge" which will keep the pieces logically separated from each other as it is in the 3 commits part of the PR.

@rpl rpl merged commit e91b062 into master May 23, 2022
@rpl rpl deleted the fix/update-to-adbkit-v3 branch May 23, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants