write id to file upon successful submission #2511
Conversation
eviljeff
requested review from
rpl and
willdurand
and removed request for
rpl
| log.info(`Generated extension ID: ${addonId}.`); | ||
| log.info('You must add the following to your manifest:'); | ||
| log.info(`"browser_specific_settings": {"gecko": "${addonId}"}`); |
There was a problem hiding this comment.
If we move saveIdToSourceDir() somewhere else (could be in this file even), then those logs could also be moved to saveIdToSourceDir(). If there is a chance that this message does not apply, we could update the content a bit (e.g. from "You must add [...]" to "Make sure you have [...] in your manifest:").
There was a problem hiding this comment.
The id is never needed for the signAddon route, while AMO doesn't allow MV3 submissions. (If we're specifically adding support for MV3 I'd prefer that in a separate PR).
We only call the function for id-less submissions for submit-addon, so it's always needed.
eviljeff
force-pushed
the
2491-save-generated-id-earlier
branch
from
8f64065 to
7fe826f
Compare
|
had to squash and rebase to address the conflicts from #2489 |
src/cmd/sign.js
Outdated
| @@ -185,28 +193,26 @@ export default function sign( | |||
| throw new Error('The extension could not be signed'); | |||
| } | |||
| result = { id: newId, downloadedFiles }; | |||
| // All information about the downloaded files would have already been | |||
| // logged by signAddon(). submitAddon() calls saveIdToSourceDir itself. | |||
There was a problem hiding this comment.
nit, saveIdToSourceDir => saveIdToFile in this inline comment?
fixes #2491 - and could address #2490 (at least in part) by clearly stating the addon id after it's available from AMO.