command: add ambient-light-lux property #15450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akemi
force-pushed
the
ambient_light_lux
branch
2 times, most recently
from
3524572 to
45f8e85
Compare
|
Download the artifacts for this pull request: |
kasper93
reviewed
Dec 8, 2024
Akemi
force-pushed
the
ambient_light_lux
branch
from
45f8e85 to
38f950d
Compare
make it observable to make it usable as a replacement for --gamma-auto.
also mention this replacement for --gamma-auto.
Akemi
force-pushed
the
ambient_light_lux
branch
from
38f950d to
2f8999f
Compare
|
hope i addressed everything and didn't forget anything. i kept the libmpv API as int, since we don't want to change the user facing interface/API, is deprecated here anyway and will be removed in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up for discussion if this is the right way to do it. not sure if it should be its own event (
MP_EVENT_AMBIENT_LIGHTING_CHANGED) or fall underMP_EVENT_WIN_STATE.added a replacement script for
--gamma-auto(implementation of https://github.com/mpv-player/mpv/blob/master/video/out/gpu/utils.c#L42-L55), removed the old usage from cocoa-cb and deprecated the libmpv api.we could properly remove
--gamma-autoand its associated functionality with the release after the next one (0.41), and maybe the deprecated libmpv API too.follow up of #14540.