Poke api #11
Poke api #11
Conversation
…the Pokemon object
# Conflicts: # .idea/misc.xml # README.md # app/build.gradle # app/src/main/java/dev/marcosfarias/pokedex/ui/dashboard/DashboardViewPagerAdapter.kt # app/src/main/java/dev/marcosfarias/pokedex/ui/dashboard/evolution/EvolutionFragment.kt # app/src/main/java/dev/marcosfarias/pokedex/utils/ListStringConverter.kt # build.gradle.kts
# Conflicts: # .idea/misc.xml # README.md # app/build.gradle # app/src/main/java/dev/marcosfarias/pokedex/ui/dashboard/DashboardViewPagerAdapter.kt # app/src/main/java/dev/marcosfarias/pokedex/ui/dashboard/evolution/EvolutionFragment.kt # app/src/main/java/dev/marcosfarias/pokedex/utils/ListStringConverter.kt # build.gradle.kts
|
I put a WIP marker, as I can't take any more chasing after refactoring screens that are based on the old API and these are merged into the master. Please everyone stop to fork the master, he is not growing this project! @mrcsxsiq please review my code, there is a lot of code here until I finish this job. Thank you! |
|
Hi @tassiolucas |
|
Hello @mrcsxsiq It is an almost sexual pleasure to be talking to you! LoL... I had sent you an email for us to set this turbine on fire in this project, however I believe that you must not have found. I am also Brazilian and I am very happy that someone from my country started this beautiful project! I'm using this as a hobby to train my skills with the new Android architecture. I just need that new screens are not introduced with the old API. I did the Merge Back with the master and came across the @naufalprakoso Evolution screen. I just need one night to refactor this screen to the new API format, serialize the Evolutions and pass new data on to the Pokemon object. And soon we will have everything ready for the Master branch walks with the data source pointing to the Pokemon API, which has a lot of other data! Soon I commit this refactoring and pass the lint so that everything is aligned with the technologies already implemented! A big hug! |
…structuring of data in the respective tables.
|
@mrcsxsiq It's ready for review! Thank you so much for your support! |
|
@tassiolucas some specific reason to add a 3rd party library instead of making calls to pokeapi with retrofit? |
|
@mrcsxsiq Well, she's not quite like a third party. She is an official of the end-point itself, only that she already has all the models and addresses of PokeAPI itself. As follows in the following documentation (https://pokeapi.co/docs/v2 & https://github.com/PokeAPI/pokekotlin). - Making use of it we disengage the responsibility of having to serialize all the items, creating all the models and putting the address of each request. Since it was specifically created for this, on each platform contemplated. Inside the SDK you can see in detail that it already uses Retrofit 2.8.1 in its Client and RxClient modes. |
|
@mrcsxsiq I am waiting for your feedback, so we can proceed to the next step! Thank you! |
Features: