[code-infra] Migrate to eslint v9 and flat config #2054

brijeshb42 · 2025-06-03T10:01:02Z

I have followed (at least) the PR section of the contributing guide.

mui-bot · 2025-06-03T10:02:22Z

Bundle size report

Bundle	Parsed Size	Gzip Size
@base-ui-components/react	0B^(0.00%)	0B^(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against cb09557

pkg-pr-new · 2025-06-03T10:02:38Z

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@2054

commit: cb09557

netlify · 2025-06-03T10:04:10Z

✅ Deploy Preview for base-ui ready!

Name	Link
🔨 Latest commit	`cb09557`
🔍 Latest deploy log	https://app.netlify.com/projects/base-ui/deploys/6865152e11bd0e00084953a2
😎 Deploy Preview	https://deploy-preview-2054--base-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Janpot · 2025-07-01T09:34:27Z

eslint.config.mjs

+      'no-restricted-imports': [
+        'error',
+        {
+          patterns: NO_RESTRICTED_IMPORTS_PATTERNS_DEEPLY_NESTED,


Isn't this already covered by an earlier rule?

eslint.config.mjs

Janpot

Added a bunch of small comments, but nothing blocking. Should we switch to using the file extension constants?

Final review for @mui/base-ui

brijeshb42 · 2025-07-02T04:16:40Z

@michaldudak Can I get a final approval ?

michaldudak · 2025-07-02T10:51:31Z

docs/scripts/reportBrokenLinks.mts

@@ -7,9 +7,11 @@ import * as jsxRuntime from 'react/jsx-runtime';
 import { evaluate } from '@mdx-js/mdx';
 import rehypeExtractToc, { type Toc, type TocEntry } from '@stefanprobst/rehype-extract-toc';
 import rehypeExportToc from '@stefanprobst/rehype-extract-toc/mdx';
+/* eslint-disable import/extensions */


We should be able to explicitly import .mjs everywhere. IIRC Typescript doesn't resolve these automatically if they are extensionless.

michaldudak · 2025-07-02T10:52:04Z

package.json

@@ -22,14 +22,14 @@
    "docs:link-check": "pnpm --filter docs link-check",
    "extract-error-codes": "cross-env MUI_EXTRACT_ERROR_CODES=true lerna run --concurrency 1 build:stable",
    "install:codesandbox": "pnpm install --no-frozen-lockfile",
-    "jsonlint": "node ./scripts/jsonlint.mjs",
+    "jsonlint": "code-infra jsonlint",


michaldudak · 2025-07-02T10:53:38Z

packages/react/src/floating-ui-react/utils/nodes.test.ts

-    { id: '3', parentId: '1', context: contextOpen },
-  ]);
-});
+describe('floating-ui-react/utils/nodes', () => {


This whole directory (packages/react/src/floating-ui-react) was copied from the Floating UI repo as we decided to maintain a local fork. It may not conform to our internal code standards fully, so we might create a separate config

brijeshb42 added the scope: code-infra Specific to the code-infra product label Jun 3, 2025

brijeshb42 force-pushed the eslint-v9 branch 3 times, most recently from f186289 to dcc072a Compare June 3, 2025 10:45

brijeshb42 mentioned this pull request Jun 3, 2025

[code-infra] Bring eslint configuration from core and bump to v9 mui/mui-public#344

Merged

brijeshb42 force-pushed the eslint-v9 branch from dcc072a to bacf14f Compare June 4, 2025 05:50

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 6, 2025

brijeshb42 force-pushed the eslint-v9 branch from bacf14f to 6b61157 Compare June 10, 2025 13:54

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 10, 2025

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 17, 2025

brijeshb42 force-pushed the eslint-v9 branch from 6b61157 to 6199e85 Compare June 18, 2025 04:34

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jun 18, 2025

brijeshb42 force-pushed the eslint-v9 branch from a72e150 to fd1a4fa Compare June 19, 2025 09:24

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 19, 2025

brijeshb42 force-pushed the eslint-v9 branch 2 times, most recently from f47145b to b698db7 Compare June 19, 2025 10:43

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 23, 2025

brijeshb42 force-pushed the eslint-v9 branch from b698db7 to cbef36b Compare June 24, 2025 14:29

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jun 24, 2025

brijeshb42 force-pushed the eslint-v9 branch from cbef36b to 60831ef Compare June 26, 2025 08:35

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 26, 2025

brijeshb42 force-pushed the eslint-v9 branch 2 times, most recently from ea7265b to 18d6189 Compare June 26, 2025 08:40

brijeshb42 marked this pull request as ready for review June 26, 2025 08:45

brijeshb42 requested a review from michaldudak as a code owner June 26, 2025 08:45

Janpot reviewed Jul 1, 2025

View reviewed changes

eslint.config.mjs Outdated Show resolved Hide resolved

Janpot reviewed Jul 1, 2025

View reviewed changes

brijeshb42 force-pushed the eslint-v9 branch 2 times, most recently from ab9370a to 62f3309 Compare July 1, 2025 11:36

brijeshb42 requested a review from michaldudak July 1, 2025 11:36

brijeshb42 force-pushed the eslint-v9 branch from 1ac6ef1 to d029297 Compare July 2, 2025 04:11

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 2, 2025

brijeshb42 force-pushed the eslint-v9 branch from d029297 to f0b4b64 Compare July 2, 2025 08:53

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 2, 2025

brijeshb42 force-pushed the eslint-v9 branch from f0b4b64 to 1a59420 Compare July 2, 2025 08:54

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 2, 2025

brijeshb42 force-pushed the eslint-v9 branch from 1a59420 to 056b1f8 Compare July 2, 2025 09:08

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jul 2, 2025

brijeshb42 force-pushed the eslint-v9 branch from 056b1f8 to 99b24b4 Compare July 2, 2025 09:33

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 2, 2025

brijeshb42 force-pushed the eslint-v9 branch from 99b24b4 to 06f3105 Compare July 2, 2025 09:46

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 2, 2025

[code-infra] Migrate to eslint v9 and flat config

6aba547

brijeshb42 force-pushed the eslint-v9 branch from 06f3105 to 6aba547 Compare July 2, 2025 10:06

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 2, 2025

michaldudak reviewed Jul 2, 2025

View reviewed changes

Review fix

cb09557

brijeshb42 force-pushed the eslint-v9 branch from a95f588 to cb09557 Compare July 2, 2025 11:17

michaldudak approved these changes Jul 2, 2025

View reviewed changes

michaldudak mentioned this pull request Jul 2, 2025

Bump eslint #2208

Closed

1 task

brijeshb42 merged commit cb54f89 into mui:master Jul 2, 2025
22 checks passed

brijeshb42 deleted the eslint-v9 branch July 2, 2025 11:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[code-infra] Migrate to eslint v9 and flat config #2054

[code-infra] Migrate to eslint v9 and flat config #2054

Uh oh!

brijeshb42 commented Jun 3, 2025

Uh oh!

mui-bot commented Jun 3, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jun 3, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jun 3, 2025 •

edited

Loading

Uh oh!

Janpot Jul 1, 2025

Uh oh!

brijeshb42 Jul 1, 2025

Uh oh!

Uh oh!

Janpot left a comment

Uh oh!

brijeshb42 commented Jul 2, 2025

Uh oh!

michaldudak Jul 2, 2025

Uh oh!

brijeshb42 Jul 2, 2025

Uh oh!

michaldudak Jul 2, 2025

Uh oh!

michaldudak Jul 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[code-infra] Migrate to eslint v9 and flat config #2054

[code-infra] Migrate to eslint v9 and flat config #2054

Uh oh!

Conversation

brijeshb42 commented Jun 3, 2025

Uh oh!

mui-bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle size report

Uh oh!

pkg-pr-new bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for base-ui ready!

Uh oh!

Janpot Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

brijeshb42 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Janpot left a comment

Choose a reason for hiding this comment

Uh oh!

brijeshb42 commented Jul 2, 2025

Uh oh!

michaldudak Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

brijeshb42 Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

michaldudak Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

michaldudak Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mui-bot commented Jun 3, 2025 •

edited

Loading

pkg-pr-new bot commented Jun 3, 2025 •

edited

Loading

netlify bot commented Jun 3, 2025 •

edited

Loading