-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[Tabs] Fix modifier keys + Left/Right Arrow key from being consumed by tab navigation #45345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tabs] Fix modifier keys + Left/Right Arrow key from being consumed by tab navigation #45345
Conversation
Netlify deploy previewhttps://deploy-preview-45345--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
…alt-arrow-key-navigation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this and it works: https://codesandbox.io/p/sandbox/material-tabs-bug-forked-4mh6ml
Probably the same logic should be applied to all modifier keys like Shift/Ctrl as well, what do you think @aarongarciah @DiegoAndai
@mushfiqbh Also would you mind adding some tests around this? I would suggest a new describe('modifier keys', () => {…})
block nested directly under this one: https://github.com/mui/material-ui/blob/master/packages/mui-material/src/Tabs/Tabs.test.js#L928
Agreed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the expected changes. @mushfiqbh Thanks for the PR.
Cherry-pick PRs will be created targeting branches: v6.x |
…y tab navigation (#45345) Co-authored-by: ZeeshanTamboli <[email protected]>
Fixes #45308
Before: https://codesandbox.io/p/sandbox/xgl5m2
After: https://codesandbox.io/p/sandbox/material-ui-cra-ts-forked-yq7vky