[docs][examples] Remove create-react-app usages #45426

CodeLeom · 2025-02-26T22:56:14Z

This PR closes #45228

I have followed (at least) the PR section of the contributing guide.

…ementation, replacing cra+tailwind+mui

…ion added

…roperability doc page

mui-bot · 2025-02-26T22:59:21Z

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f8ab11f

DiegoAndai

Hey @CodeLeom, thanks for working on this!

@mapache-salvaje may I ask you to review this? It's about CRA: #45228

DiegoAndai · 2025-03-05T17:46:39Z

examples/material-ui-vite-ts/package.json

Why delete these?

It was a duplicate, the file still exist

CodeLeom

It was a duplicate, the file still exist

CodeLeom · 2025-03-09T19:19:05Z

examples/material-ui-vite-ts/package.json

It was a duplicate, the file still exist

mapache-salvaje

Thanks for taking this on @CodeLeom ! 🙌 This review covers the content of the docs pages that were changed. I'll follow up shortly once I've had more time to dig into this branch and confirm that all of the examples are working as intended.

docs/data/material/guides/content-security-policy/content-security-policy.md

docs/data/material/guides/minimizing-bundle-size/minimizing-bundle-size.md

docs/data/material/guides/typescript/typescript.md

docs/data/material/integrations/interoperability/interoperability.md

Signed-off-by: Ayodele Aransiola <[email protected]>

mapache-salvaje

Thanks @CodeLeom ! The examples you added all look good to me. Can you also remove the existing CRA examples from that same folder? material-ui-cra etc. We'll also need to remove them from the Example Projects page and replace them with our new ones. Once that's done this PR should close out the issue linked.

We will also need to update all of the Material UI examples to use v7 now that it's stable, but I think we can wait for a follow-up PR to take care of that so the scope of this one doesn't get too big.

CodeLeom · 2025-04-10T23:16:46Z

Thanks @CodeLeom ! The examples you added all look good to me. Can you also remove the existing CRA examples from that same folder? material-ui-cra etc. We'll also need to remove them from the Example Projects page and replace them with our new ones. Once that's done this PR should close out the issue linked.

We will also need to update all of the Material UI examples to use v7 now that it's stable, but I think we can wait for a follow-up PR to take care of that so the scope of this one doesn't get too big.

Thank you, I will work on it. I will also make a follow-up PR for the v7 update

ZeeshanTamboli

@CodeLeom Could you resolve the file conflicts?

…removal

ZeeshanTamboli

Left some important changes that need to be done. Also, can you fix the CI failures?

docs/data/material/integrations/interoperability/interoperability.md

docs/data/material/guides/minimizing-bundle-size/minimizing-bundle-size.md

docs/data/material/integrations/interoperability/interoperability.md

docs/data/material/integrations/styled-components/styled-components.md

examples/material-ui-vite-tailwind-ts/src/App.tsx

examples/material-ui-vite-ts/README.md

examples/material-ui-vite-ts/package.json

Co-authored-by: Zeeshan Tamboli <[email protected]> Signed-off-by: Ayodele Aransiola <[email protected]>

CodeLeom · 2025-04-29T13:03:09Z

Left some important changes that need to be done. Also, can you fix the CI failures?

how can I fix the CI failures?

Resolved

ZeeshanTamboli · 2025-04-30T08:28:01Z

@CodeLeom I’ve made the expected changes — everything looks good to me now. Thanks for your contribution!

@Janpot Could you review, especially the updates to the Minimizing bundle size page?

@mapache-salvaje Mind taking a look as well?

CodeLeom · 2025-04-30T09:13:31Z

Minimizing bundle size

Thank you so much for all the efforts

Janpot · 2025-04-30T09:22:25Z

@Janpot Could you review, especially the updates to the Minimizing bundle size page?

I removed a redundant paragraph, removed the section about import boundaries (these are now enforced by our package structure) and added a section about auto-importing in vscode.

Great work all!

…m/material-ui into deprecated-react-removal

mapache-salvaje · 2025-04-30T14:36:26Z

Nice job everybody, thanks so much for all of your work on this @CodeLeom !!

CodeLeom added 9 commits February 26, 2025 20:54

doc: remove create create app from the official integration

fb44fba

doc: update example collection with an updated vite+tailwind+mui impl…

3c99891

…ementation, replacing cra+tailwind+mui

doc: modify the cra link to vite setup example

73abccb

doc: remove cra explanation and replace with a Vite explanation

4e61c51

doc: remove cra usage of babel to minimize bundle size. Vite explanat…

ab54075

…ion added

doc: remove migration to cra example

6076ee3

doc: remove cra appearance

7e53859

doc: add vite implementation of styled components and update the inte…

a930c0d

…roperability doc page

doc: update styled-component page with vite example links

f4f8384

zannager added docs Improvements or additions to the documentation deprecation New deprecation message labels Feb 28, 2025

zannager requested review from Janpot and DiegoAndai February 28, 2025 12:19

DiegoAndai reviewed Mar 5, 2025

View reviewed changes

DiegoAndai requested a review from mapache-salvaje March 5, 2025 17:47

mnajdova changed the title ~~Deprecated react removal~~ [docs][examples] Remove create react app usages Mar 7, 2025

mnajdova added examples Relating to /examples and removed deprecation New deprecation message labels Mar 7, 2025

CodeLeom commented Mar 9, 2025

View reviewed changes

examples/material-ui-vite-ts/package.json

Copy link

Contributor Author

CodeLeom Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a duplicate, the file still exist

mapache-salvaje reviewed Mar 18, 2025

View reviewed changes

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 20, 2025

Merge branch 'master' into deprecated-react-removal

1018d74

Signed-off-by: Ayodele Aransiola <[email protected]>

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 22, 2025

fix: suggestion included

7279542

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 25, 2025

ZeeshanTamboli requested a review from mapache-salvaje March 30, 2025 07:54

mapache-salvaje reviewed Apr 8, 2025

View reviewed changes

fix: remove the appearance of CRA example files

1bbe9b5

CodeLeom requested a review from ZeeshanTamboli April 28, 2025 21:25

ZeeshanTamboli reviewed Apr 29, 2025

View reviewed changes

CodeLeom added 2 commits April 29, 2025 09:13

Merge remote-tracking branch 'upstream/master' into deprecated-react-…

aee9394

…removal

dev: remove styled component from example codes and reference

ad4303d

CodeLeom requested a review from ZeeshanTamboli April 29, 2025 08:22

CodeLeom mentioned this pull request Apr 29, 2025

[docs][examples] Update Material UI example to use V7 #46040

Closed

ZeeshanTamboli previously requested changes Apr 29, 2025

View reviewed changes

CodeLeom and others added 3 commits April 29, 2025 13:58

Update examples/material-ui-vite-tailwind-ts/src/App.tsx

7d2044a

Co-authored-by: Zeeshan Tamboli <[email protected]> Signed-off-by: Ayodele Aransiola <[email protected]>

Update examples/material-ui-vite-ts/README.md

d715134

Co-authored-by: Zeeshan Tamboli <[email protected]> Signed-off-by: Ayodele Aransiola <[email protected]>

Update examples/material-ui-vite-ts/README.md

4c8a0b2

Co-authored-by: Zeeshan Tamboli <[email protected]> Signed-off-by: Ayodele Aransiola <[email protected]>

ZeeshanTamboli added 4 commits April 29, 2025 19:31

pnpm prettier

e86c84f

review changes

21df4a0

resolve conflicts

5b9b596

fix lint and docs link

78e50b7

ZeeshanTamboli mentioned this pull request Apr 8, 2025

[docs] Deprecate create-react-app #45228

Closed

4 tasks

lint

d843d56

remove create-react-app fixture from bundling tests

2bce911

Janpot added 2 commits April 30, 2025 11:13

Update minimizing-bundle-size.md

ae57c15

Update minimizing-bundle-size.md

07dae62

Janpot approved these changes Apr 30, 2025

View reviewed changes

ZeeshanTamboli added 3 commits April 30, 2025 17:12

Merge branch 'master' into deprecated-react-removal

5fa2bfb

Merge branch 'deprecated-react-removal' of https://github.com/CodeLeo…

1ce1ad1

…m/material-ui into deprecated-react-removal

Fix VS Code casing

f8ab11f

ZeeshanTamboli merged commit 13fa2ac into mui:master Apr 30, 2025
24 checks passed

Uh oh!

[docs][examples] Remove create-react-app usages #45426

[docs][examples] Remove create-react-app usages #45426

Uh oh!

Conversation

CodeLeom commented Feb 26, 2025 • edited by ZeeshanTamboli Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Netlify deploy preview

Bundle size report

Uh oh!

DiegoAndai left a comment

Choose a reason for hiding this comment

Uh oh!

DiegoAndai Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

CodeLeom Mar 9, 2025

Choose a reason for hiding this comment

Uh oh!

CodeLeom left a comment

Choose a reason for hiding this comment

Uh oh!

CodeLeom Mar 9, 2025

Choose a reason for hiding this comment

Uh oh!

mapache-salvaje left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mapache-salvaje left a comment

Choose a reason for hiding this comment

Uh oh!

CodeLeom commented Apr 10, 2025

Uh oh!

ZeeshanTamboli left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZeeshanTamboli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CodeLeom commented Apr 29, 2025

Uh oh!

ZeeshanTamboli commented Apr 30, 2025

Uh oh!

CodeLeom commented Apr 30, 2025

Uh oh!

Janpot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mapache-salvaje commented Apr 30, 2025

Uh oh!

Uh oh!

CodeLeom commented Feb 26, 2025 •

edited by ZeeshanTamboli

Loading

mui-bot commented Feb 26, 2025 •

edited

Loading

ZeeshanTamboli left a comment •

edited

Loading

Janpot commented Apr 30, 2025 •

edited

Loading