Skip to content

[docs-infra] Remove false-positive Vale rules #45843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

oliviertassinari
Copy link
Member

Issue spotted in mui/mui-x#17281 (comment)

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product labels Apr 7, 2025
@mui-bot
Copy link

mui-bot commented Apr 7, 2025

Netlify deploy preview

https://deploy-preview-45843--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 96ad275

@zannager zannager requested a review from alexfauquette April 8, 2025 08:42
@oliviertassinari oliviertassinari merged commit fc8508d into mui:master Apr 8, 2025
24 of 25 checks passed
@oliviertassinari oliviertassinari deleted the fix-client-side branch April 8, 2025 09:57
@oliviertassinari
Copy link
Member Author

@zannager A side not, it would have made more sense to ask review from Sam, considering the issue that was linked in the PR description, but I should have requested him, my bad.

@zannager
Copy link
Member

zannager commented Apr 9, 2025

@oliviertassinari Honestly, I was considering requesting a review from both Alex and Sam, but ended up picking Alex since he's on the docs-infra - though in hindsight, Sam might have made more sense for continuity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants