Skip to content

[material-ui][CardActionArea] Add slots and slotProps #45866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2025

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Apr 10, 2025

@sai6855 sai6855 added component: card This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material enhancement This is not a bug, nor a new feature v6.x needs cherry-pick The PR should be cherry-picked to master after merge labels Apr 10, 2025
@mui-bot
Copy link

mui-bot commented Apr 10, 2025

Netlify deploy preview

https://deploy-preview-45866--material-ui.netlify.app/

CardActionArea: parsed: +2.31% , gzip: +2.05%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 301fd34

@sai6855 sai6855 requested a review from siriwatknp April 10, 2025 07:59
}
>;

export interface CardActionAreaOwnerState extends CardActionAreaProps {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export interface CardActionAreaOwnerState extends CardActionAreaProps {}
export interface CardActionAreaOwnerState extends Omit<CardActionAreaProps, 'slots' | 'slotProps'> {}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent cyclic types

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here 711a683

@sai6855 sai6855 requested a review from siriwatknp April 10, 2025 14:16
@sai6855 sai6855 merged commit 9e4c31b into mui:master Apr 11, 2025
22 checks passed
Copy link

Cherry-pick PRs will be created targeting branches: v6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: card This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants