Skip to content

[performance] Remove unnecessary clsx() usages #46084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented May 5, 2025

This pull request simplifies the codebase by removing unnecessary uses of the clsx utility in several components within the material-ui package

Same as mui/mui-x#17690.

@mui-bot
Copy link

mui-bot commented May 5, 2025

Netlify deploy preview

https://deploy-preview-46084--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 9f7588d

@sai6855 sai6855 added package: material-ui Specific to @mui/material enhancement This is not a bug, nor a new feature labels May 5, 2025
@sai6855 sai6855 requested a review from ZeeshanTamboli May 5, 2025 10:09
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@sai6855 sai6855 merged commit b9df933 into mui:master May 5, 2025
22 of 23 checks passed
@oliviertassinari oliviertassinari changed the title [material-ui] Remove unnecessary clsx usages [material-ui] Remove unnecessary clsx() usages May 7, 2025
@oliviertassinari oliviertassinari added performance and removed package: material-ui Specific to @mui/material labels May 7, 2025
@oliviertassinari oliviertassinari changed the title [material-ui] Remove unnecessary clsx() usages [performance] Remove unnecessary clsx() usages May 7, 2025
@oliviertassinari
Copy link
Member

I wonder about the usage of https://github.com/temoncher/eslint-plugin-clsx to avoid this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants