Skip to content

[system] Update the type for borderRadius #46154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

codiini
Copy link
Contributor

@codiini codiini commented May 16, 2025

This PR fixes #46128

@mui-bot
Copy link

mui-bot commented May 16, 2025

Netlify deploy preview

https://deploy-preview-46154--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 128e339

@zannager zannager added package: system Specific to @mui/system customization: theme Centered around the theming features labels May 16, 2025
@zannager zannager requested a review from siriwatknp May 16, 2025 10:05
@ZeeshanTamboli ZeeshanTamboli changed the title [shape] Update the type for borderRadius [theme] Update the type for borderRadius May 19, 2025
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution!

pushed some more tests.

@ZeeshanTamboli ZeeshanTamboli changed the title [theme] Update the type for borderRadius [system] Update the type for borderRadius May 19, 2025
@ZeeshanTamboli ZeeshanTamboli merged commit 67076a4 into mui:master May 19, 2025
21 checks passed
@CommanderRedYT
Copy link

How would one multiply the value after the change? I have plenty of uses where I multiplied the borderRadius by some factor

@paztis
Copy link

paztis commented Jun 6, 2025

As I said in this comment #46128 (comment) for me it is a regression as you do the exact opposite PR here: #34076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: theme Centered around the theming features package: system Specific to @mui/system typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type ThemeOptions.shape.borderRadius
7 participants