[docs][templates] Fix rendering of logos in dark mode #46221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-46221--material-ui.netlify.app/ Bundle size report |
sai6855
commented
May 26, 2025
|
|
||
| const whiteLogos = [ | ||
| const darkModeLogos = [ |
There was a problem hiding this comment.
I renamed variable names to show their purpose, not what they actually are.
| @@ -30,8 +30,19 @@ const logoStyle = { | |||
| }; | |||
|
|
|||
| export default function LogoCollection() { | |||
| const theme = useTheme(); | |||
| const logos = theme.palette.mode === 'light' ? darkLogos : whiteLogos; | |||
There was a problem hiding this comment.
There are 2 issues with this code
- theme.palatte.mode isn't returning updated
modevalue when user changes theme.useColorSchemeis returning correct mode, hence i used that systemmode is not properly handled here.
ZeeshanTamboli
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46219
preview: https://deploy-preview-46221--material-ui.netlify.app/material-ui/getting-started/templates/marketing-page/