Skip to content

[code-infra] Move chai to peerDep #46227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025
Merged

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented May 27, 2025

This would allow X to move to chai v5 mui/mui-x#17575

It is probably a more sane approach too

@JCQuintas JCQuintas self-assigned this May 27, 2025
@JCQuintas JCQuintas added scope: code-infra Specific to the core-infra product enhancement This is not a bug, nor a new feature labels May 27, 2025
@mui-bot
Copy link

mui-bot commented May 27, 2025

Netlify deploy preview

https://deploy-preview-46227--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d42710e

@JCQuintas JCQuintas added enhancement This is not a bug, nor a new feature and removed enhancement This is not a bug, nor a new feature labels May 27, 2025
@JCQuintas JCQuintas requested a review from a team May 27, 2025 17:37
@JCQuintas JCQuintas marked this pull request as ready for review May 27, 2025 17:37
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer with the vitest migration in core, so should be only temporary

@JCQuintas JCQuintas merged commit a4cc1cd into mui:master May 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants