Skip to content

[code-infra] Use flat eslint config #46258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 2, 2025
Merged

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Jun 2, 2025

Currently getting this warning Multiple projects found, consider using a single tsconfigwithreferencesto speed up, or usenoWarnOnMultipleProjects to suppress this warning while linting.
So seems there's some scope to improve the lint speed.

Remove "eslint.useFlatConfig": false from vscode settings as it is not needed now.

Perf

For perf, we'll have to monitor as it gets run more on the CI, but so far, the flat config run has been in the range of 3min 30-40sec and old config has been around 2min 45sec.

Locally, the perf has been in the same range of around 70 to 80sec (running the same pnpm eslint:ci command without any caching) for both old and new config. But to add, the flat config takes almost 10sec extra than the legacy config.

@mui-bot
Copy link

mui-bot commented Jun 2, 2025

Netlify deploy preview

https://deploy-preview-46258--material-ui.netlify.app/

Bundle size report

Bundle Parsed Size Gzip Size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 2fd1888

@brijeshb42 brijeshb42 force-pushed the eslint-flat branch 2 times, most recently from 4eaf1e7 to a00bf44 Compare June 2, 2025 12:59
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 3, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 3, 2025
@brijeshb42 brijeshb42 force-pushed the eslint-flat branch 4 times, most recently from 6f8ae49 to 0db1b2e Compare June 3, 2025 09:08
@brijeshb42 brijeshb42 force-pushed the eslint-flat branch 3 times, most recently from d2457a7 to 0408101 Compare June 4, 2025 06:34
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 5, 2025
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jun 11, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 16, 2025
@brijeshb42 brijeshb42 force-pushed the eslint-flat branch 5 times, most recently from d840eb9 to 63585a6 Compare June 16, 2025 16:02
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 16, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 17, 2025
@brijeshb42 brijeshb42 force-pushed the eslint-flat branch 2 times, most recently from 7121c94 to f240c5e Compare June 17, 2025 03:47
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 2, 2025
@brijeshb42 brijeshb42 requested a review from DiegoAndai July 2, 2025 06:44
@mnajdova mnajdova requested a review from Janpot July 2, 2025 07:14
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review is in #46258 (review)

@siriwatknp
Copy link
Member

I tested with pnpm eslint:ci and I got this error. Do you get the same?

image

@brijeshb42
Copy link
Contributor Author

I tested with pnpm eslint:ci and I got this error. Do you get the same?

Fixed

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works on my machine.

@brijeshb42 brijeshb42 merged commit 35a95be into mui:master Jul 2, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants