-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[code-infra] Use flat eslint config #46258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Netlify deploy previewhttps://deploy-preview-46258--material-ui.netlify.app/ Bundle size report
|
4eaf1e7
to
a00bf44
Compare
6f8ae49
to
0db1b2e
Compare
d2457a7
to
0408101
Compare
d840eb9
to
63585a6
Compare
7121c94
to
f240c5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My review is in #46258 (review)
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works on my machine.
Currently getting this warning
Multiple projects found, consider using a single
tsconfigwith
referencesto speed up, or use
noWarnOnMultipleProjectsto suppress this warning
while linting.So seems there's some scope to improve the lint speed.
Remove
"eslint.useFlatConfig": false
from vscode settings as it is not needed now.Perf
For perf, we'll have to monitor as it gets run more on the CI, but so far, the flat config run has been in the range of 3min 30-40sec and old config has been around 2min 45sec.
Locally, the perf has been in the same range of around 70 to 80sec (running the same
pnpm eslint:ci
command without any caching) for both old and new config. But to add, the flat config takes almost 10sec extra than the legacy config.