-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[infra] Create update PR on every canary publish for internal packages #46367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Netlify deploy previewhttps://deploy-preview-46367--material-ui.netlify.app/ Bundle size report@mui/material parsed: 0B(0.00%) gzip: 0B(0.00%) Show details for 100 more bundles (86 more not shown)@mui/lab/AdapterDateFns parsed: 0B(0.00%) gzip: 0B(0.00%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why follow canary? What will consume the stable releases?
We will likely not create stable releases for these packages. Maybe to signal big breaking changes, but the goal is to have changes in these packages propagate to dependent projects as quickly and painlessly as possible. I'm choosing to use canary releases because:
Related discussion: mui/mui-public#344 (comment) |
@Janpot I think that makes sense. Maybe for maintenance branches (e.g. |
these packages should never end up as a dependency of our products. they're intended for build tooling, and shared docs functionality |
Right, but do we ever need to improve or fix tooling for previous versions of |
renovatebot only creates PRs against the master branch, so LTS branches will just stay on whatever version they were when the branch was created. we'll have to manually cherry pick updates to internal dependencies if we need to backport them. it's an incentive to keep them backwards compatible. we could also decide to cut a stable release of the tooling each time we split off a LTS branch. |
We can decide to follow this up with auto merging, but we'll probably have to tweak branch rules for that.
open questions: