[code-infra] Bring eslint configuration from core and bump to v9 #344
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "eslint.useFlatConfig": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import type { Handler } from '@netlify/functions'; | ||
| import zlib from 'zlib'; | ||
| import util from 'util'; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import axios from 'axios'; | ||
|
|
||
| function getMainBundleLabel(bundleId: string): string { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| function flip(data) { | ||
| return Object.fromEntries(Object.entries(data).map(([key, value]) => [value, key])); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import { request } from 'graphql-request'; | ||
|
|
||
| interface LabelTimelineItem { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import { request } from 'graphql-request'; | ||
|
|
||
| interface PullRequest { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import { request } from 'graphql-request'; | ||
|
|
||
| export async function queryPRswithoutReviewer() { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import { includeIgnoreFile } from '@eslint/compat'; | ||
| import { defineConfig } from 'eslint/config'; | ||
| import * as path from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { | ||
| createBaseConfig, | ||
| createTestConfig, | ||
| EXTENSION_TEST_FILE, | ||
| } from '@mui/internal-code-infra/eslint'; | ||
|
|
||
| const filename = fileURLToPath(import.meta.url); | ||
| const dirname = path.dirname(filename); | ||
|
|
||
| export default defineConfig( | ||
| includeIgnoreFile(path.join(dirname, '.gitignore')), | ||
| includeIgnoreFile(path.join(dirname, '.eslintignore')), | ||
| { | ||
| name: 'Base config', | ||
| extends: createBaseConfig({ | ||
| baseDirectory: dirname, | ||
| }), | ||
| rules: { | ||
| // No time for this | ||
| 'react/prop-types': 'off', | ||
| 'jsx-a11y/control-has-associated-label': 'off', | ||
| 'jsx-a11y/no-autofocus': 'off', | ||
| }, | ||
| settings: { | ||
| 'import/resolver': { | ||
| typescript: { | ||
| project: ['tsconfig.json'], | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| files: [ | ||
| // matching the pattern of the test runner | ||
| `**/*${EXTENSION_TEST_FILE}`, | ||
| ], | ||
| extends: createTestConfig(), | ||
| }, | ||
| { | ||
| files: ['apps/**/*'], | ||
| rules: { | ||
| 'react/jsx-one-expression-per-line': 'off', | ||
| }, | ||
| }, | ||
| { | ||
| files: ['packages/bundle-size-checker/**/*'], | ||
| rules: { | ||
| // Allow .js file extensions in import statements for ESM compatibility | ||
| 'import/extensions': [ | ||
|
There was a problem hiding this comment. Would it make sense to make the default so that in .mjs/.mts files extensions are required? |
||
| 'error', | ||
| 'ignorePackages', | ||
| { | ||
| js: 'always', | ||
| mjs: 'always', | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| export default { | ||
| rules: { | ||
| // keeps test simple | ||
| 'no-unreachable': 'off', | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| __fixtures__ | ||
| *.tsbuildinfo | ||
| *.test.mjs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # @mui/internal-code-infra | ||
|
|
||
| Build scripts and configs to be used across MUI repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,76 @@ | ||||||
| { | ||||||
| "name": "@mui/internal-code-infra", | ||||||
| "version": "0.0.1", | ||||||
LukasTy marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| "description": "Infra scripts and configs to be used across MUI repos.", | ||||||
| "type": "module", | ||||||
| "repository": { | ||||||
| "type": "git", | ||||||
| "url": "https://github.com/mui/mui-public.git", | ||||||
| "directory": "packages/mui-internal-code-infra" | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| }, | ||||||
| "sideEffects": false, | ||||||
| "exports": { | ||||||
| "./package.json": "./package.json", | ||||||
| "./prettier": { | ||||||
| "default": "./src/prettier.mjs" | ||||||
| }, | ||||||
| "./eslint": { | ||||||
| "default": "./src/eslint/index.mjs" | ||||||
| } | ||||||
| }, | ||||||
| "scripts": { | ||||||
| "typescript": "tsc -p tsconfig.json", | ||||||
| "test": "pnpm -w test --project @mui/internal-code-infra" | ||||||
| }, | ||||||
| "dependencies": { | ||||||
| "@eslint/eslintrc": "^3.3.1", | ||||||
| "eslint-config-airbnb": "^19.0.4", | ||||||
| "eslint-config-airbnb-base": "^15.0.0", | ||||||
| "eslint-config-prettier": "^10.1.5", | ||||||
| "eslint-import-resolver-typescript": "^4.4.3", | ||||||
| "eslint-module-utils": "^2.12.1", | ||||||
| "eslint-plugin-import": "^2.32.0", | ||||||
| "eslint-plugin-jsx-a11y": "^6.10.2", | ||||||
| "eslint-plugin-mocha": "^11.1.0", | ||||||
| "eslint-plugin-react": "^7.37.5", | ||||||
| "eslint-plugin-react-compiler": "^19.1.0-rc.2", | ||||||
| "eslint-plugin-react-hooks": "^6.0.0-rc.1", | ||||||
| "eslint-plugin-testing-library": "^7.5.3", | ||||||
| "@next/eslint-plugin-next": "^15.0.0", | ||||||
| "globals": "^16.2.0", | ||||||
| "minimatch": "^10.0.3", | ||||||
| "typescript-eslint": "^8.35.0" | ||||||
| }, | ||||||
| "peerDependencies": { | ||||||
| "eslint": "^9.0.0", | ||||||
| "prettier": "^3.0.0" | ||||||
|
There was a problem hiding this comment. I assume that There was a problem hiding this comment. It is not needed because in the repo, you don't directly import it or try to use it in some way. It is already configured for you. |
||||||
| }, | ||||||
| "peerDependenciesMeta": { | ||||||
| "eslint": { | ||||||
| "optional": true | ||||||
| }, | ||||||
| "prettier": { | ||||||
| "optional": true | ||||||
| } | ||||||
| }, | ||||||
| "devDependencies": { | ||||||
| "@next/eslint-plugin-next": "^15.3.3", | ||||||
| "@types/eslint-plugin-jsx-a11y": "^6.10.0", | ||||||
| "@types/estree": "^1.0.8", | ||||||
| "@types/estree-jsx": "^1.0.5", | ||||||
| "@typescript-eslint/parser": "^8.35.0", | ||||||
| "@typescript-eslint/rule-tester": "^8.35.0", | ||||||
| "eslint": "^9.29.0", | ||||||
| "prettier": "^3.5.3", | ||||||
| "typescript-eslint": "^8.35.0" | ||||||
| }, | ||||||
| "files": [ | ||||||
| "build", | ||||||
| "src", | ||||||
| "README.md", | ||||||
| "LICENSE" | ||||||
| ], | ||||||
| "publishConfig": { | ||||||
| "access": "public" | ||||||
| } | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { FlatCompat } from '@eslint/eslintrc'; | ||
| import * as tseslint from 'typescript-eslint'; | ||
|
|
||
| /** | ||
| * @param {Object} options - Configuration options. | ||
| * @param {string} [options.baseDirectory] - The base directory for the configuration. | ||
| * @returns {import('eslint').Linter.Config[]} | ||
| */ | ||
| export function createAirbnbConfig({ baseDirectory } = {}) { | ||
| if (!baseDirectory) { | ||
| throw new Error('"baseDirectory" option is required for Airbnb configuration.'); | ||
| } | ||
| const compat = new FlatCompat({ | ||
| baseDirectory, | ||
| }); | ||
| const airbnbConfig = compat.extends('eslint-config-airbnb'); | ||
| return /** @type {import('eslint').Linter.Config[]} */ (tseslint.config(airbnbConfig)); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just remove? Or does this have a function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a leftover. 🙈