Skip to content

[docs][data grid] Revise the Row Grouping doc #16217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Apr 22, 2025

Conversation

mapache-salvaje
Copy link
Contributor

Part of the ongoing auditing/editing project.

@mapache-salvaje mapache-salvaje added docs Improvements or additions to the documentation scope: data grid Changes or issues related to the data grid product feature: Row grouping Related to the data grid Row grouping feature type: enhancement This is not a bug, nor a new feature labels Jan 16, 2025
@mui-bot
Copy link

mui-bot commented Jan 16, 2025


{{"demo": "RowGroupingBasicExample.js", "bg": "inline", "defaultCodeOpen": false}}

:::info
If you are looking for row grouping on the server-side, see [server-side row grouping](/x/react-data-grid/server-side-data/row-grouping/).
This document covers client-side implementation.
For row grouping on the server side, see [server-side row grouping](/x/react-data-grid/server-side-data/row-grouping/).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Vale warning is incorrect 😭 I'll open a separate PR to address it

Screenshot 2025-02-28 at 9 57 48 AM

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 17, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 17, 2025
@mapache-salvaje mapache-salvaje marked this pull request as ready for review March 17, 2025 18:06
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 18, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 18, 2025
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates, thank you for working on it.

I left a few suggestions.

@cherniavskii cherniavskii added needs cherry-pick The PR should be auto-cherry-picked to a version branch after merge—add a version label as target v7.x labels Mar 20, 2025
Copy link

Thanks for adding a type label to the PR! 👍

@@ -1,2 +1,3 @@
Broken links found by `docs:link-check` that exist:

- https://mui.com/x/react-data-grid/row-grouping/#disable-the-row-grouping
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is in a blog post from the monorepo, so I'll have to open a separate PR over there to fix it

@mapache-salvaje mapache-salvaje merged commit 0482991 into mui:master Apr 22, 2025
21 checks passed
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Apr 22, 2025
Signed-off-by: Sam Sycamore <[email protected]>
Signed-off-by: mapache-salvaje <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Co-authored-by: Bilal Shafi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation feature: Row grouping Related to the data grid Row grouping feature needs cherry-pick The PR should be auto-cherry-picked to a version branch after merge—add a version label as target scope: data grid Changes or issues related to the data grid product type: enhancement This is not a bug, nor a new feature v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants