[charts] Move tooltipGetter to seriesConfig
#16331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCQuintas
added
type: enhancement
|
Deploy preview: https://deploy-preview-16331--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #16331 will not alter performanceComparing Summary
|
JCQuintas
changed the title
tooltipGetter to plugin systemtooltipGetter to seriesConfig
alexfauquette
approved these changes
Jan 27, 2025
| export type TooltipGetter<T extends ChartSeriesType> = (params: { | ||
| series: ChartSeriesDefaultized<T>; | ||
| getColor: (dataIndex: number) => string; | ||
| item: ChartItemIdentifier<T> | null; |
There was a problem hiding this comment.
Maybe identifier or itemIdentifier woudl make more sens. From item we could expect to gat any value related to the item
alexfauquette
requested changes
Jan 27, 2025
alexfauquette
approved these changes
Jan 27, 2025
A-s-h-o-k
pushed a commit
to A-s-h-o-k/mui-x
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow different series types to provide their own legendGetter config