[DataGrid] Fix order of onClick prop on toolbar buttons
#16356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenanYusuf
added
scope: data grid
|
Deploy preview: https://deploy-preview-16356--material-ui-x.netlify.app/ |
arminmeh
reviewed
Jan 27, 2025
packages/x-data-grid/src/components/toolbar/GridToolbarColumnsButton.tsx
Show resolved
Hide resolved
arminmeh
approved these changes
Jan 28, 2025
|
Cherry-pick PRs will be created targeting branches: v7.x |
A-s-h-o-k
pushed a commit
to A-s-h-o-k/mui-x
that referenced
this pull request
Feb 4, 2025
oliviertassinari
removed
the
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16355
onClickneeds to come after{...buttonProps}to ensure the button behavior works as expected when anonClickprop is passed to the toolbar button.