Skip to content

[DataGrid] Refactor: remove base input label & adornment #16646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 19, 2025

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Feb 18, 2025

Part of the design-system agnostic work.

Remove the baseInputLabel and baseInputAdornment as those can be avoided and kept as a material implementation detail.

@romgrk romgrk added breaking change Introduces changes that are not backward compatible. scope: data grid Changes or issues related to the data grid product labels Feb 18, 2025
@romgrk romgrk requested a review from a team February 18, 2025 21:51
@romgrk romgrk changed the title [DataGrid] Refactor: remove input label & adornment [DataGrid] Refactor: remove base input label & adornment Feb 18, 2025
@mui-bot
Copy link

mui-bot commented Feb 18, 2025

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 19, 2025
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 19, 2025
@romgrk romgrk merged commit eb71710 into mui:master Feb 19, 2025
18 checks passed
@romgrk romgrk deleted the refactor-agnostic-input-extras branch February 19, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Introduces changes that are not backward compatible. scope: data grid Changes or issues related to the data grid product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants