Skip to content

[DataGrid] Fix showColumnVerticalBorder prop #16715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

KenanYusuf
Copy link
Member

The column headers were using showCellVerticalBorder to determine whether the border should be enabled between items instead of showColumnVerticalBorder.

@KenanYusuf KenanYusuf added scope: data grid Changes or issues related to the data grid product type: regression A bug that reintroduces previously resolved issues or breaks existing functionality. type: bug A bug or unintended behavior in the components. labels Feb 24, 2025
@mui-bot
Copy link

mui-bot commented Feb 24, 2025

Deploy preview: https://deploy-preview-16715--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 95078ce

@KenanYusuf KenanYusuf added needs cherry-pick The PR should be auto-cherry-picked to a version branch after merge—add a version label as target v7.x labels Feb 24, 2025
@KenanYusuf KenanYusuf requested a review from a team February 24, 2025 17:01
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I noticed a weird behavior the other day in https://deploy-preview-14611--material-ui-x.netlify.app/x/react-data-grid/components/toolbar/#settings-menu, but forgot to report it.
Thanks for fixing it!

@KenanYusuf KenanYusuf merged commit 5269b07 into mui:master Feb 25, 2025
18 checks passed
@KenanYusuf KenanYusuf deleted the fix-showColumnVerticalBorder-prop branch February 25, 2025 09:40
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

@oliviertassinari oliviertassinari removed the type: bug A bug or unintended behavior in the components. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs cherry-pick The PR should be auto-cherry-picked to a version branch after merge—add a version label as target scope: data grid Changes or issues related to the data grid product type: regression A bug that reintroduces previously resolved issues or breaks existing functionality. v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants