-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[charts] Add axis highlight to the radar #16868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Deploy preview: https://deploy-preview-16868--material-ui-x.netlify.app/ Updated pages: |
CodSpeed Performance ReportMerging #16868 will not alter performanceComparing Summary
|
* - slice: display a slice around the highlighted value. Recommended for radar with a single series. | ||
* The default value is computed depending on the number of series provided. | ||
*/ | ||
axisHighlightShape: 'points' | 'slice'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to highlight slices? 🤔
If yes, should they be less opaque (0.9 maybe)? 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it make sense. The different configuration make it look weird. But the point look also weird for single series. That's why I ended up with the current default
Follow up on #16406
Main topics:
getAxisValue
function even though most of the code is similar. Manipulating angles and the fact that 0° and 360° are the same will pollute the main one.TODO before merging