Skip to content

[code-infra] Avoid loading package.json with relative path #16931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 12, 2025

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 12, 2025

We can't reach outside of the rootDir (i.e. ./src/ folder) as during build, cjs and esm will be outputted to different levels in the build folder and make one of the cases fail. Instead, I propose to compile in the version as we do in core.

Fix #13530 (comment)

Copy link

github-actions bot commented Mar 12, 2025

Thanks for adding a type label to the PR! 👍

@Janpot Janpot added the type: regression A bug that reintroduces previously resolved issues or breaks existing functionality. label Mar 12, 2025
@mui-bot
Copy link

mui-bot commented Mar 12, 2025

Deploy preview: https://deploy-preview-16931--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 811047e

@Janpot Janpot changed the title Don't load package.json relative [code-infra] Don't load package.json with relative path Mar 12, 2025
@Janpot Janpot changed the title [code-infra] Don't load package.json with relative path [code-infra] Avoid loading package.json with relative path Mar 12, 2025
Copy link
Member

@hasdfa hasdfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it seems to fix the CSB import error.

@Janpot Janpot merged commit df806a7 into mui:master Mar 12, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A bug that reintroduces previously resolved issues or breaks existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants