[charts] Remove fireEvent usage from tests
#17006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JCQuintas
commented
Mar 17, 2025
JCQuintas
commented
- I have followed (at least) the PR section of the contributing guide.
JCQuintas
added
test
scope: charts
|
Deploy preview: https://deploy-preview-17006--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #17006 will not alter performanceComparing Summary
|
bernardobelchior
approved these changes
Mar 18, 2025
Comment on lines
-191
to
+198
| fireEvent.click(rectangles[0]); | ||
| await user.click(rectangles[0]); |
There was a problem hiding this comment.
It's not 100% clear that this is better:
- It feels slower to run in the CI.
- It doesn't force people to understand what's going on when implementing the code at the JS event granularity level.
- Test
In exchange, we get more reliability, but is this gain real? I don't recall seeing one case where we had regressions because we relied on firing the wrong events.
We will see with more time
oliviertassinari
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.