Skip to content

[charts] advance time in charts regression tests #17420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented Apr 17, 2025

This is necessary to run animation frames before taking a screenshot. This will also unblock changes in #17285 because the test in that PR requires an animation frame to run before the print dialog is shown.

@bernardobelchior bernardobelchior added test scope: charts Changes or issues related to the charts product labels Apr 17, 2025
Copy link

github-actions bot commented Apr 17, 2025

Thanks for adding a type label to the PR! 👍

@mui-bot
Copy link

mui-bot commented Apr 17, 2025

Deploy preview: https://deploy-preview-17420--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 81cb823

Copy link

codspeed-hq bot commented Apr 17, 2025

CodSpeed Performance Report

Merging #17420 will not alter performance

Comparing bernardobelchior:regression-advance-time-charts (81cb823) with master (881de93)

Summary

✅ 8 untouched benchmarks

@bernardobelchior bernardobelchior force-pushed the regression-advance-time-charts branch 7 times, most recently from 27c0926 to 81cb823 Compare April 17, 2025 15:09
@bernardobelchior bernardobelchior marked this pull request as ready for review April 17, 2025 15:13
@alexfauquette alexfauquette merged commit efdf1bb into mui:master Apr 18, 2025
22 checks passed
@bernardobelchior bernardobelchior deleted the regression-advance-time-charts branch April 21, 2025 06:49
@oliviertassinari oliviertassinari added core Covers general upkeep, such as minor refactoring, typo fixes, or structural changes. type: enhancement This is not a bug, nor a new feature and removed maintenance labels May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Covers general upkeep, such as minor refactoring, typo fixes, or structural changes. scope: charts Changes or issues related to the charts product test type: enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants