Skip to content

[DataGridPro] Fix locales.ts export #17433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

[DataGridPro] Fix locales.ts export #17433

merged 2 commits into from
Apr 18, 2025

Conversation

lhilgert9
Copy link
Contributor

Fixes #17432.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

Thanks for adding a type label to the PR! 👍

@arminmeh arminmeh added type: bug A bug or unintended behavior in the components. scope: data grid Changes or issues related to the data grid product labels Apr 18, 2025
@arminmeh arminmeh changed the title [data grid] Rename locales.ts to locales/index.ts [data grid] Export locales.ts properly for pro and premium package Apr 18, 2025
@arminmeh arminmeh mentioned this pull request Apr 18, 2025
Closed
@arminmeh arminmeh requested a review from a team April 18, 2025 08:51
@arminmeh arminmeh mentioned this pull request Apr 18, 2025
Closed
@arminmeh arminmeh enabled auto-merge (squash) April 18, 2025 09:51
@mui-bot
Copy link

mui-bot commented Apr 18, 2025

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-17433--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d173119

@arminmeh arminmeh merged commit eb63014 into mui:master Apr 18, 2025
19 checks passed
@arminmeh arminmeh changed the title [data grid] Export locales.ts properly for pro and premium package [DataGridPro] Export locales.ts properly for pro and premium package Apr 18, 2025
@arminmeh arminmeh added the plan: Pro Impact at least one Pro user label Apr 18, 2025
@arminmeh arminmeh changed the title [DataGridPro] Export locales.ts properly for pro and premium package [DataGridPro] Export locales.ts properly Apr 18, 2025
@arminmeh arminmeh changed the title [DataGridPro] Export locales.ts properly [DataGridPro] Fix locales.ts export Apr 18, 2025
This was referenced Apr 18, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminmeh arminmeh arminmeh approved these changes

Assignees
No one assigned
Labels
plan: Pro Impact at least one Pro user scope: data grid Changes or issues related to the data grid product type: bug A bug or unintended behavior in the components.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Missing exports for locales in pro and premium package
3 participants
@lhilgert9 @mui-bot @arminmeh