Skip to content

[core] Remove eslint from codemod spec files #17443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 28, 2025
Merged

[core] Remove eslint from codemod spec files #17443

merged 9 commits into from
Apr 28, 2025

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Apr 18, 2025 •
edited
Loading

The following eslintignore path 've been introduced recently in #17392

/packages/x-codemod/src/**/*.spec.ts
/packages/x-codemod/src/**/*.spec.tsx

Do you have an issue with keeping it?

  • No issue -> I merge this PR that removes the now useless esling-ignore in impacted files
  • you see issue -> I revert the .eslintignore

@alexfauquette alexfauquette added core Covers general upkeep, such as minor refactoring, typo fixes, or structural changes. scope: code-infra labels Apr 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

Thanks for adding a type label to the PR! 👍

@mui-bot
Copy link

mui-bot commented Apr 18, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-17443--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ddf7d0e

cherniavskii
cherniavskii approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO ignoring spec files by eslint makes sense to me 👍🏻

LukasTy
LukasTy approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it looks like the existing configuration is/was broken. 🙈
I'm all for the suggestion. 👌

@alexfauquette alexfauquette merged commit 6e54152 into mui:master Apr 28, 2025
21 checks passed
@oliviertassinari oliviertassinari added type: enhancement This is not a bug, nor a new feature and removed maintenance labels May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@bernardobelchior bernardobelchior bernardobelchior approved these changes

@cherniavskii cherniavskii cherniavskii approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees
No one assigned
Labels
core Covers general upkeep, such as minor refactoring, typo fixes, or structural changes. type: enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexfauquette @mui-bot @LukasTy @bernardobelchior @cherniavskii @oliviertassinari