[DataGridPro] Avoid proptypes warnings with header filters in React 17 #17482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
scope: data grid
|
Thanks for adding a type label to the PR! 👍 |
cherniavskii
force-pushed
the
supress-proptypes-warnings-react-17
branch
from
50f21cb to
07d4fc3
Compare
|
Deploy preview: https://deploy-preview-17482--material-ui-x.netlify.app/ |
arminmeh
approved these changes
Apr 22, 2025
KenanYusuf
approved these changes
Apr 22, 2025
|
Cherry-pick PRs will be created targeting branches: v7.x |
bernardobelchior
pushed a commit
to bernardobelchior/mui-x
that referenced
this pull request
Apr 22, 2025
oliviertassinari
added
type: bug
4 tasks
oliviertassinari
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://mui.zendesk.com/agent/tickets/26834
We use the
useId()hook to generate IDs for these props.But in React 17,
useId()returnsundefinedas the initial value, which triggers the propTypes warning:https://github.com/mui/material-ui/blob/e3d807e35a1b410dfb0d5240e72b8a8846768c03/packages/mui-utils/src/useId/useId.ts#L7-L20
Since we're going to remove propTypes anyway, I think it's OK to mark these specific props as optional.