Skip to content

[core][docs] Fix <kbd> a11y #17536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 24, 2025

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation core Covers general upkeep, such as minor refactoring, typo fixes, or structural changes. a11y Accessibility: Issues or PRs related to making the application usable for people with disabilities. labels Apr 24, 2025
Copy link
Member

@KenanYusuf KenanYusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about nested kbd, thanks for fixing!

@oliviertassinari oliviertassinari merged commit dbfc3fe into mui:master Apr 25, 2025
27 checks passed
@oliviertassinari oliviertassinari deleted the fix-kbd-a11y branch April 25, 2025 14:41
@oliviertassinari oliviertassinari added the type: regression A bug that reintroduces previously resolved issues or breaks existing functionality. label Apr 30, 2025
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Apr 30, 2025

TIL about nested kbd, thanks for fixing!

@KenanYusuf It's actually more nuanced than this; the thread in mui/material-ui#24269 (comment) covered it.

Both seems ok, the only difference I see is what happens with text wrapping

SCR-20250501-blfx

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/kbd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility: Issues or PRs related to making the application usable for people with disabilities. core Covers general upkeep, such as minor refactoring, typo fixes, or structural changes. docs Improvements or additions to the documentation type: regression A bug that reintroduces previously resolved issues or breaks existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants