[code-infra] Further remove clock=fake and add async act for datagrid
#17563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-17563--material-ui-x.netlify.app/ |
JCQuintas
commented
Apr 27, 2025
| const cell = getCell(0, 0); | ||
| fireUserEvent.mousePress(cell); | ||
| }).not.to.throw(); | ||
| it('should not crash when the row is removed during the click', async () => { |
There was a problem hiding this comment.
expect doesn't support async, so I just removed the expects, if something throws inside the test it will fail.
JCQuintas
changed the title
clock=fake and add async act for datagrid
romgrk
approved these changes
Apr 27, 2025
oliviertassinari
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as with previous PRs, goal is to trim down changes in the main PR, though there were adjustments I had to make for mocha/karma 🫠
Most notable changes are commented