Skip to content

[DataGrid] Fix: circular reference error #17591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Apr 28, 2025

The theme may contains circular references, so it needs special handling for stringification & hashing.

Closes #17442
Closes #17521

Before: https://codesandbox.io/p/devbox/x-react-data-grid-getting-started-forked-nl9s3p?from-embed=&workspaceId=ws_3SJ17h6UtA66t5QH97aCiT

@romgrk romgrk added type: bug A bug or unintended behavior in the components. scope: data grid Changes or issues related to the data grid product labels Apr 28, 2025
@romgrk romgrk requested a review from a team April 28, 2025 12:29
@mui-bot
Copy link

mui-bot commented Apr 28, 2025

Deploy preview: https://deploy-preview-17591--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d3a0d66

@cherniavskii cherniavskii added the type: regression A bug that reintroduces previously resolved issues or breaks existing functionality. label Apr 28, 2025
@michelengelen michelengelen removed the type: bug A bug or unintended behavior in the components. label Apr 28, 2025
@romgrk romgrk merged commit 9a04f2d into mui:master Apr 28, 2025
23 of 24 checks passed
@romgrk romgrk deleted the fix-circular-ref branch April 28, 2025 13:26
@mui mui deleted a comment from github-actions bot Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: data grid Changes or issues related to the data grid product type: regression A bug that reintroduces previously resolved issues or breaks existing functionality.
Projects
None yet
4 participants