[DateRangePicker] Fix to reset range position after closing mobile Picker #17631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
type: bug
LukasTy
commented
Apr 30, 2025
| )('should return back to start range position after reopening a range picker', async () => { | ||
| const pickerType = pickerParams.type as PickerRangeComponentType; | ||
| // If transitions are disabled, the `onExited` event is not triggered | ||
| config.disabled = false; |
There was a problem hiding this comment.
Had to enable Transitions for this test, otherwise the onExited callback is not triggered. 🙈
|
Deploy preview: https://deploy-preview-17631--material-ui-x.netlify.app/ |
flaviendelangle
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, the range position is reset to
startonly when the Desktop range Picker is closed.This PR fixes to do the same for Mobile Picker and adds to ensure this behavior is stable.